CI: run on maintenance branches as well#51
Merged
tylerjereddy merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
Collaborator
Author
|
oh right, I should do the same for wheel test CI config... one sec |
* There is no matching issue for this patch, but I think it would be helpful if we allow CI to run on maintenance branches so that we can check that i.e., backported bug fixes are "ok" on release branches as well. * Also, there is no need to run the CI again on `main` after merging a PR--it should suffice to check that CI is passing before the merge (GHA will automatically try merging the branch into `main` before the tests run in the PR, so basically just wastes electricity). The reason for running CI on pushes to release/maintenance branches is that sometimes projects will setup for automatic wheel builds on merge to release branches (we don't have that yet, but doesn't hurt to have it on I don't think, merges to release branches will be rare anyway). * This configuration is lifted directly from upstream at: https://github.com/scipy/scipy/blob/main/.github/workflows/linux.yml#L3 where it has been working well for years.
tylerjereddy
force-pushed
the
treddy_run_ci_on_maintenance_branches
branch
from
202d668 to
4eaf911
Compare
Collaborator
Author
|
The CI is passing and this has been working upstream for years. I'll use a bit of "release manager discretion" to self-merge in this case, since this is useful to have on release branches moving forward and we're about to cut a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no matching issue for this patch, but I think it would be helpful if we allow CI to run on maintenance branches so that we can check that i.e., backported bug fixes are "ok" on release branches as well.
Also, there is no need to run the CI again on
mainafter merging a PR--it should suffice to check that CI is passing before the merge (GHA will automatically try merging the branch intomainbefore the tests run in the PR, so basically just wastes electricity). The reason for running CI on pushes to release/maintenance branches is that sometimes projects will setup for automatic wheel builds on merge to release branches (we don't have that yet, but doesn't hurt to have it on I don't think, merges to release branches will be rare anyway).This configuration is lifted directly from upstream at: https://github.com/scipy/scipy/blob/main/.github/workflows/linux.yml#L3 where it has been working well for years.